Ensure we're loading .env in UTF-8 #1965
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since python-dotenv does not provide this capacity, we do the reading part ourselves instead (into a StringIO). It supports this at least, fortunately.
uranusjr
force-pushed
the
dotenv-encoding
branch
from
b514586
to
4953602
Compare
|
I don’t get the Mercury failure… |
techalchemy
reviewed
Apr 12, 2018
| @@ -0,0 +1,29 @@ | |||
| try: | |||
There was a problem hiding this comment.
does this really need its own file
single function => probably should stay in the main file to avoid the overhead
There was a problem hiding this comment.
It used to contain a subclass of StringIO to abstract away some text stream logic between Python 2 and 3, but I ended up just reading the whole thing out (since the dotenv file would be reasonably small anyway). Also I wanted to trim the 2000-line monster core.py as much as possible… but no, this doesn’t need its own file.
|
Note to self: Also need to fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since python-dotenv does not provide this capacity, we do the reading part ourselves instead (into a StringIO). It supports this at least, fortunately.
Fix #1963.